More persistent test page #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Now it's only half broken)
Merged
mAAdhaTTah
reviewed
Mar 10, 2019
mAAdhaTTah
reviewed
Mar 10, 2019
|
If Edge has problems w/ local/session storage, do we need try / catch's for it? |
|
All done. |
mAAdhaTTah
approved these changes
Mar 10, 2019
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the test page remember the language and code last used.
The language is stored in the URL hash similar to the download page.
The code last used is stored in
sessionStoragelike the current theme.This feature has been tested in Chrome, Firefox, and Opera.
Edge has severe problems with
sessionStorageandlocalStoragewhen the test page is opened from the local file system. But it does work when served from a (local) server.